fix: added handling for new key - duration_nano in traces #6658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to b6159a7 in 12 seconds
More details
- Looked at
40lines of code in3files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. frontend/src/container/TimeSeriesView/index.tsx:32
- Draft comment:
Consider defining a constant for 'durationNano' and 'duration_nano' to avoid repetition and potential errors in future changes. This applies to similar checks in other files as well. - Reason this comment was not posted:
Confidence changes required:50%
The code changes are consistent across files, ensuring both 'durationNano' and 'duration_nano' are handled. However, the code could be improved for maintainability by using a constant for these keys.
2. frontend/src/container/TracesExplorer/ListView/utils.tsx:102
- Draft comment:
Avoid using inline styles. Consider using CSS classes or styled components instead. This is also applicable in other parts of the code where inline styles are used. - Reason this comment was not posted:
Comment was not on a valid diff hunk.
Workflow ID: wflow_hZzwP0HPyFePJ6Og
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Issues / PR's
https://github.com/SigNoz/engineering-pod/issues/2095
Screenshots
NA
Affected Areas and Manually Tested Areas
Important
Add handling for
duration_nanokey alongsidedurationNanoin various components and utilities.duration_nanokey in addition todurationNanoinTimeSeriesViewContainerinindex.tsx.getSpanOrderParaminutil.tsto handleduration_nano.getListColumnsinutils.tsxto supportduration_nanokey for rendering duration in milliseconds.This description was created by
for b6159a7. It will automatically update as commits are pushed.